Library Management System - Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
57	0	0	105

Files

Files	I	W	E
net/ramapuram/thomas/dao/UserDao.java	0	0	1
net/ramapuram/thomas/dao/hibernate/GenericDaoHibernate.java	0	0	2
net/ramapuram/thomas/dao/hibernate/LookupDaoHibernate.java	0	0	1
net/ramapuram/thomas/dao/hibernate/UserDaoHibernate.java	0	0	1
net/ramapuram/thomas/model/acquisition/Book.java	0	0	19
net/ramapuram/thomas/model/circulation/Issue.java	0	0	15
net/ramapuram/thomas/model/opac/Comment.java	0	0	13
net/ramapuram/thomas/model/opac/Reservation.java	0	0	12
net/ramapuram/thomas/service/MailEngine.java	0	0	1
net/ramapuram/thomas/service/UserManager.java	0	0	1
net/ramapuram/thomas/service/UserSecurityAdvice.java	0	0	1
net/ramapuram/thomas/service/impl/GenericManagerImpl.java	0	0	3
net/ramapuram/thomas/service/impl/RoleManagerImpl.java	0	0	2
net/ramapuram/thomas/service/impl/UserManagerImpl.java	0	0	2
net/ramapuram/thomas/webapp/action/UserAction.java	0	0	1
net/ramapuram/thomas/webapp/jsp/EscapeXml.java	0	0	1
net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolver.java	0	0	22
net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolverListener.java	0	0	2
net/ramapuram/thomas/webapp/listener/StartupListener.java	0	0	1
net/ramapuram/thomas/webapp/listener/UserCounterListener.java	0	0	1
net/ramapuram/thomas/webapp/search/CompassConfigurationPostProcessor.java	0	0	2
net/ramapuram/thomas/webapp/util/RequestUtil.java	0	0	1

Rules

Rules	Violations	Severity
Translation	0	Error
FileLength	0	Error
FileTabCharacter eachLine: `"true"`	0	Error
JavadocMethod scope: `"protected"` allowMissingPropertyJavadoc: `"true"` allowThrowsTagsForSubclasses: `"true"` allowUndeclaredRTE: `"true"`	9	Error
JavadocType scope: `"protected"`	0	Error
JavadocVariable scope: `"protected"`	0	Error
JavadocStyle scope: `"protected"` checkFirstSentence: `"false"`	0	Error
ConstantName format: `"^log$\|^[A-Z][A-Z0-9](_[A-Z0-9]+)$"`	0	Error
LocalFinalVariableName	0	Error
LocalVariableName	0	Error
MemberName	0	Error
MethodName	0	Error
PackageName	0	Error
ParameterName	0	Error
StaticVariableName	0	Error
TypeName	0	Error
AvoidStarImport	0	Error
IllegalImport	0	Error
RedundantImport	0	Error
UnusedImports	0	Error
LineLength max: `"120"`	4	Error
MethodLength	0	Error
ParameterNumber	0	Error
EmptyForIteratorPad	0	Error
MethodParamPad	0	Error
NoWhitespaceAfter	0	Error
NoWhitespaceBefore allowLineBreaks: `"true"` tokens: `"DOT"`	0	Error
OperatorWrap	28	Error
ParenPad	0	Error
TypecastParenPad	0	Error
WhitespaceAfter	0	Error
WhitespaceAround tokens: `"ASSIGN"`	0	Error
ModifierOrder	0	Error
RedundantModifier	0	Error
AvoidNestedBlocks	0	Error
EmptyBlock	0	Error
LeftCurly	4	Error
NeedBraces	32	Error
RightCurly	0	Error
DoubleCheckedLocking	0	Error
EmptyStatement	0	Error
EqualsHashCode	0	Error
IllegalInstantiation	0	Error
InnerAssignment	0	Error
MissingSwitchDefault	0	Error
RedundantThrows	24	Error
SimplifyBooleanExpression	0	Error
SimplifyBooleanReturn	0	Error
FinalClass	0	Error
HideUtilityClassConstructor	1	Error
InterfaceIsType	0	Error
VisibilityModifier packageAllowed: `"true"` protectedAllowed: `"true"`	0	Error
ArrayTypeStyle	0	Error
FinalParameters tokens: `"CTOR_DEF"`	3	Error
UpperEll	0	Error
NestedIfDepth max: `"3"`	0	Error
NestedTryDepth	0	Error
ExplicitInitialization	0	Error

Details

net/ramapuram/thomas/dao/UserDao.java

Violation	Message	Line
	Redundant throws: 'UsernameNotFoundException' is unchecked exception.	26

net/ramapuram/thomas/dao/hibernate/GenericDaoHibernate.java

Violation	Message	Line
	Parameter sessionFactory should be final.	60
	Missing a Javadoc comment.	74

net/ramapuram/thomas/dao/hibernate/LookupDaoHibernate.java

Violation	Message	Line
	Expected @param tag for 'sessionFactory'.	29

net/ramapuram/thomas/dao/hibernate/UserDaoHibernate.java

Violation	Message	Line
	Redundant throws: 'UsernameNotFoundException' is unchecked exception.	73

net/ramapuram/thomas/model/acquisition/Book.java

Violation	Message	Line
	'if' construct must use '{}'s.	108
	'if' construct must use '{}'s.	109
	'if' construct must use '{}'s.	113
	'if' construct must use '{}'s.	114
	'if' construct must use '{}'s.	115
	'if' construct must use '{}'s.	116
	'if' construct must use '{}'s.	117
	'if' construct must use '{}'s.	119
	'if' construct must use '{}'s.	121
	'if' construct must use '{}'s.	122
	'+' should be on a new line.	142
	'+' should be on a new line.	143
	'+' should be on a new line.	144
	'+' should be on a new line.	145
	'+' should be on a new line.	146
	'+' should be on a new line.	147
	'+' should be on a new line.	148
	'+' should be on a new line.	149
	'+' should be on a new line.	150

net/ramapuram/thomas/model/circulation/Issue.java

Violation	Message	Line
	'if' construct must use '{}'s.	88
	'if' construct must use '{}'s.	89
	'if' construct must use '{}'s.	93
	'if' construct must use '{}'s.	94
	'if' construct must use '{}'s.	95
	'if' construct must use '{}'s.	96
	'if' construct must use '{}'s.	97
	'if' construct must use '{}'s.	98
	'+' should be on a new line.	116
	'+' should be on a new line.	117
	'+' should be on a new line.	118
	'+' should be on a new line.	119
	'+' should be on a new line.	120
	'+' should be on a new line.	121
	'+' should be on a new line.	122

net/ramapuram/thomas/model/opac/Comment.java

Violation	Message	Line
	'if' construct must use '{}'s.	80
	'if' construct must use '{}'s.	81
	'if' construct must use '{}'s.	85
	'if' construct must use '{}'s.	86
	'if' construct must use '{}'s.	87
	'if' construct must use '{}'s.	88
	'if' construct must use '{}'s.	89
	'+' should be on a new line.	106
	'+' should be on a new line.	107
	'+' should be on a new line.	108
	'+' should be on a new line.	109
	'+' should be on a new line.	110
	'+' should be on a new line.	111

net/ramapuram/thomas/model/opac/Reservation.java

Violation	Message	Line
	'if' construct must use '{}'s.	70
	'if' construct must use '{}'s.	71
	'if' construct must use '{}'s.	75
	'if' construct must use '{}'s.	76
	'if' construct must use '{}'s.	77
	Line is longer than 120 characters.	77
	'if' construct must use '{}'s.	79
	'+' should be on a new line.	95
	'+' should be on a new line.	96
	'+' should be on a new line.	97
	'+' should be on a new line.	98
	'+' should be on a new line.	99

net/ramapuram/thomas/service/MailEngine.java

Violation	Message	Line
	Redundant throws: 'MailException' is unchecked exception.	74

net/ramapuram/thomas/service/UserManager.java

Violation	Message	Line
	Redundant throws: 'UsernameNotFoundException' is unchecked exception.	39

net/ramapuram/thomas/service/UserSecurityAdvice.java

Violation	Message	Line
	Line is longer than 120 characters.	72

net/ramapuram/thomas/service/impl/GenericManagerImpl.java

Violation	Message	Line
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	68
	Parameter genericDao should be final.	68

net/ramapuram/thomas/service/impl/RoleManagerImpl.java

Violation	Message	Line
	Missing a Javadoc comment.	20
	Parameter roleDao should be final.	21

net/ramapuram/thomas/service/impl/UserManagerImpl.java

Violation	Message	Line
	Missing a Javadoc comment.	35
	Redundant throws: 'UsernameNotFoundException' is unchecked exception.	120

net/ramapuram/thomas/webapp/action/UserAction.java

Violation	Message	Line
	'+' should be on a new line.	96

net/ramapuram/thomas/webapp/jsp/EscapeXml.java

Violation	Message	Line
	Utility classes should not have a public or default constructor.	32

net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolver.java

Violation	Message	Line
	'{' should be on the previous line.	63
	Redundant throws: 'NullPointerException' is unchecked exception.	69
	Redundant throws: 'PropertyNotFoundException' is subclass of 'ELException'.	69
	Redundant throws: 'PropertyNotFoundException' is unchecked exception.	69
	Redundant throws: 'ELException' is unchecked exception.	69
	'{' should be on the previous line.	70
	Redundant throws: 'NullPointerException' is unchecked exception.	76
	Redundant throws: 'PropertyNotFoundException' is subclass of 'ELException'.	76
	Redundant throws: 'PropertyNotFoundException' is unchecked exception.	76
	Redundant throws: 'ELException' is unchecked exception.	76
	'{' should be on the previous line.	77
	Redundant throws: 'NullPointerException' is unchecked exception.	98
	Redundant throws: 'PropertyNotFoundException' is subclass of 'ELException'.	98
	Redundant throws: 'PropertyNotFoundException' is unchecked exception.	98
	Redundant throws: 'ELException' is unchecked exception.	98
	'{' should be on the previous line.	99
	Redundant throws: 'NullPointerException' is unchecked exception.	106
	Redundant throws: 'PropertyNotFoundException' is subclass of 'ELException'.	106
	Redundant throws: 'PropertyNotFoundException' is unchecked exception.	106
	Redundant throws: 'PropertyNotWritableException' is subclass of 'ELException'.	106
	Redundant throws: 'PropertyNotWritableException' is unchecked exception.	106
	Redundant throws: 'ELException' is unchecked exception.	106

net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolverListener.java

Violation	Message	Line
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	42

net/ramapuram/thomas/webapp/listener/StartupListener.java

Violation	Message	Line
	Line is longer than 120 characters.	68

net/ramapuram/thomas/webapp/listener/UserCounterListener.java

Violation	Message	Line
	Line is longer than 120 characters.	158

net/ramapuram/thomas/webapp/search/CompassConfigurationPostProcessor.java

Violation	Message	Line
	Missing a Javadoc comment.	16
	Redundant throws: 'ConfigurationException' is unchecked exception.	16

net/ramapuram/thomas/webapp/util/RequestUtil.java

Violation	Message	Line
	'if' construct must use '{}'s.	95

Project Information

Project Documentation

Checkstyle Results

Summary

Files

Rules

Details

net/ramapuram/thomas/dao/UserDao.java

net/ramapuram/thomas/dao/hibernate/GenericDaoHibernate.java

net/ramapuram/thomas/dao/hibernate/LookupDaoHibernate.java

net/ramapuram/thomas/dao/hibernate/UserDaoHibernate.java

net/ramapuram/thomas/model/acquisition/Book.java

net/ramapuram/thomas/model/circulation/Issue.java

net/ramapuram/thomas/model/opac/Comment.java

net/ramapuram/thomas/model/opac/Reservation.java

net/ramapuram/thomas/service/MailEngine.java

net/ramapuram/thomas/service/UserManager.java

net/ramapuram/thomas/service/UserSecurityAdvice.java

net/ramapuram/thomas/service/impl/GenericManagerImpl.java

net/ramapuram/thomas/service/impl/RoleManagerImpl.java

net/ramapuram/thomas/service/impl/UserManagerImpl.java

net/ramapuram/thomas/webapp/action/UserAction.java

net/ramapuram/thomas/webapp/jsp/EscapeXml.java

net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolver.java

net/ramapuram/thomas/webapp/jsp/EscapeXmlELResolverListener.java

net/ramapuram/thomas/webapp/listener/StartupListener.java

net/ramapuram/thomas/webapp/listener/UserCounterListener.java

net/ramapuram/thomas/webapp/search/CompassConfigurationPostProcessor.java

net/ramapuram/thomas/webapp/util/RequestUtil.java